Skip to content

Fix GitHub Actions ref check and update packaging license metadata#98

Closed
FindHao wants to merge 2 commits intomainfrom
findhao/fix_pyproject
Closed

Fix GitHub Actions ref check and update packaging license metadata#98
FindHao wants to merge 2 commits intomainfrom
findhao/fix_pyproject

Conversation

@FindHao
Copy link
Copy Markdown
Member

@FindHao FindHao commented Sep 10, 2025

This PR refines CI logic and corrects packaging metadata.

  • Adjust GitHub Actions workflow to consistently use github.ref_type for tag detection in nightly publish job.
  • Update pyproject.toml to use canonical license = "BSD-3-Clause" and include license-files for proper distribution metadata.

These changes improve release correctness for both nightly and stable builds.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 10, 2025
@FindHao FindHao changed the title Switch project.license to SPDX string ("BSD-3-Clause") and add license-files to resolve setuptools deprecation. Fix GitHub Actions ref check and update packaging license metadata Sep 10, 2025
Summary:
This commit modifies the license configuration in the `pyproject.toml` file to use a simpler format. The license is now specified as a string, and a new field for license files has been added to include the LICENSE file.

Changes:
- Changed `license` from a table format to a string format.
- Added `license-files` to specify the LICENSE file.

This update streamlines the license declaration for better clarity and compliance.
Summary:
This commit updates the nightly PyPI publish workflow to use the correct syntax for checking the GitHub reference type. The change ensures that the condition evaluates properly during the build process.

Changes:
- Modified the reference type check from `${GITHUB_REF_TYPE}` to `${{ github.ref_type }}` in `.github/workflows/nightly-pypi.yml`.

This adjustment enhances the reliability of the workflow by aligning with the correct GitHub Actions context syntax.
@FindHao FindHao force-pushed the findhao/fix_pyproject branch from fc5ffba to 917c6f0 Compare September 11, 2025 00:21
@FindHao FindHao marked this pull request as ready for review September 11, 2025 00:21
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@FindHao has imported this pull request. If you are a Meta employee, you can view this in D82171592.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@FindHao merged this pull request in ad917ac.

@FindHao FindHao deleted the findhao/fix_pyproject branch October 2, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants