Draft
Conversation
Member
|
@mbappai can you remove commented code? |
Contributor
Author
|
Yeah ofcourse, commented code has no much relevance. I just left them there incase I might want to do a quick revert |
Member
|
Also I think we should not go with context for now, I find it complicated to understand than props, at least when state is used in parent - child, wdyt? |
Contributor
Author
|
What i'm thinking is, we should just leave this PR at the draft stage. Since we already have a working app, performance or any optimisation wouldn't be worth restructuring some of the core parts of the application. So what I propose is to just use what we already have and i'll just go ahead and memoize the SongList component to prevent the unnecessary re-renders. wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.