Skip to content

feat: Integrate metabrainz notifications#1192

Open
fettuccinae wants to merge 4 commits intometabrainz:metabrainz-notificationsfrom
fettuccinae:metabrainz-notifications
Open

feat: Integrate metabrainz notifications#1192
fettuccinae wants to merge 4 commits intometabrainz:metabrainz-notificationsfrom
fettuccinae:metabrainz-notifications

Conversation

@fettuccinae
Copy link

Added metabrainzNotifications module in server/helpers with fetchToken , sendNotification and sendMultipleNotifications methods. They fetch OAuth access tokens from Redis queue and if not available, they fetch it from metabrainz.org and store it in Redis and send notifications to metabrainz.org .

Areas of Impact:
No existing behavior is affected. These methods provide a foundation for sending user notifications in future.

@fettuccinae
Copy link
Author

@MonkeyDo Could you please create a metabrainz-notifications branch so I can target this PR to it?

Currently, oauth is handled under musicbrainz domain and if I understand it correctly, it will be soon moved to metabrainz.org. That's why I used metabrainz.org/oauth2/token for token URL. For local development, we can pull the latest metabrainz-notification branch to test this PR.

@MonkeyDo MonkeyDo changed the base branch from master to metabrainz-notifications November 13, 2025 12:28
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR ! ❤️

I have some comments before actually testing the feature.
I might need your help to hold my hand with the testing setup :)
You mention pulling the metabrainz-notification branch from MeB, but what else do I need to set myself up locally?

@fettuccinae fettuccinae requested a review from MonkeyDo November 19, 2025 10:26
@fettuccinae
Copy link
Author

fettuccinae commented Nov 19, 2025

@MonkeyDo Thanks for the detailed review, I've implemented the changes.

I might need your help to hold my hand with the testing setup :)

Please bare with me for the local dev setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments