feat: Integrate metabrainz notifications#1192
feat: Integrate metabrainz notifications#1192fettuccinae wants to merge 4 commits intometabrainz:metabrainz-notificationsfrom
Conversation
|
@MonkeyDo Could you please create a metabrainz-notifications branch so I can target this PR to it? Currently, oauth is handled under musicbrainz domain and if I understand it correctly, it will be soon moved to metabrainz.org. That's why I used |
MonkeyDo
left a comment
There was a problem hiding this comment.
Thanks for opening this PR ! ❤️
I have some comments before actually testing the feature.
I might need your help to hold my hand with the testing setup :)
You mention pulling the metabrainz-notification branch from MeB, but what else do I need to set myself up locally?
…h related config values in oauth block
|
@MonkeyDo Thanks for the detailed review, I've implemented the changes.
Please bare with me for the local dev setup. |
Added
metabrainzNotificationsmodule inserver/helperswithfetchToken,sendNotificationandsendMultipleNotificationsmethods. They fetch OAuth access tokens from Redis queue and if not available, they fetch it from metabrainz.org and store it in Redis and send notifications to metabrainz.org .Areas of Impact:
No existing behavior is affected. These methods provide a foundation for sending user notifications in future.