complete the jsdoc in FormatEntity.ts#1210
complete the jsdoc in FormatEntity.ts#1210garvthakre wants to merge 2 commits intometabrainz:masterfrom
Conversation
|
hey @MonkeyDo i just add this JSDoc can u do a quick review and give me any suggestions ,whenever you have a moment . |
MonkeyDo
left a comment
There was a problem hiding this comment.
Hello @garvthakre, sorry for the delays!
The doc look fine, I would just ask that you separate the return type of the function to resolve a linting issue (and for legibility) as the line is now very long.
And if you could resolve the trailing space issue as well that would be great, thanks !
|
Hey @MonkeyDo Just following up on this so I can move ahead with the next changes. Whenever you get time to take a look, please let me know . |
|
Hi @garvthakre Sorry again for my delays, I totally missed your message...
You did well to confirm, I got confused with the output of the failing check here: https://github.com/metabrainz/bookbrainz-site/pull/1210/checks?check_run_id=57321434620 The line causing the linting warning is the last line (541) as the line is too long.
Similarly, the linting error is not from this PR, but rather from #1203 and has since been fixed, so you can ignore it. |
|
@MonkeyDo Thanks for this and i am currently converting files from js to tsx bcoz i noticed there are already some files in tsx ,so is there anything that i need to keep in mind for that or any specific folder that i should ignore . |
I'm not sure I understand the question. |
|
@MonkeyDo ,can u close this one also, if everything is correct. |
Problem
The
formatSearchResponsefunction insrc/api/helpers/formatEntityData.tswas missing a JSDoc block, while other exported functions in the same file already include detailed documentation.Solution
Added a complete JSDoc comment for the
formatSearchResponsefunction, following the existing documentation format used in the file. The new JSDoc explains parameters, return value, and provides an example usage to improve readability and maintain consistency.Areas of Impact
Only documentation has been updated:
src/api/helpers/formatEntityData.ts