BB-872: feat(editor): Add language-specific sort name generation to improve guessing#1212
Draft
atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
Draft
BB-872: feat(editor): Add language-specific sort name generation to improve guessing#1212atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
atharvsp02 wants to merge 1 commit intometabrainz:masterfrom
Conversation
…for most used languages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sort name guessing was too simplistic - only moved the last word to front, ignoring language-specific naming conventions. This caused incorrect sort names for different languages. The language dropdown existed but wasn't used for sort name generation.
Issue link: https://tickets.metabrainz.org/browse/BB-872
Solution
Implemented language-aware sort name generation that uses the selected language dropdown:
guess-case-util.tswith language-specific parsing functionsAreas of Impact
Components Modified:
guess-case-util.ts- New centralized sort name logicsort-name-field.tsx- Simplified, imports language-awaremakeSortNamename-section.js- Field reordering and language ISO code integrationUser Experience
Screenshots