BB-399: feat(editor): Add checkbox to copy title language to content language#1214
Open
atharvsp02 wants to merge 2 commits intometabrainz:masterfrom
Open
BB-399: feat(editor): Add checkbox to copy title language to content language#1214atharvsp02 wants to merge 2 commits intometabrainz:masterfrom
atharvsp02 wants to merge 2 commits intometabrainz:masterfrom
Conversation
5f68227 to
74c27c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When adding or editing Works and Editions, users must manually select the same language twice - once for the title and again for the content language. This can lead to mistakes
Issue link: https://tickets.metabrainz.org/browse/BB-399
Solution
Areas of Impact
Modified files:
name-section/actions.ts- New thunks for checkbox and language syncname-section/reducer.js- Added checkbox statename-section/name-section.js- Added checkbox UIwork-section/actions.ts,work-section/reducer.ts- Action type renameedition-section/reducer.ts- Added undefined fallbackBehaviors affected:
Screenshots:
Before:
After:
Let me know if you have any suggestions or changes you’d like me to make.