Convert registration-auth.js to Typescript#1228
Open
garvthakre wants to merge 1 commit intometabrainz:masterfrom
Open
Convert registration-auth.js to Typescript#1228garvthakre wants to merge 1 commit intometabrainz:masterfrom
garvthakre wants to merge 1 commit intometabrainz:masterfrom
Conversation
Contributor
Author
|
hey @MonkeyDo , i just converted this small file ,can u check it and give your review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR is part of the ongoing TypeScript migration of the BookBrainz codebase. The registration-auth component is currently written in JavaScript with PropTypes for type checking, which provides less type safety compared to TypeScript's compile-time type checking.
Solution
This PR converts registration-auth.js to TypeScript by:
1.Renaming the file from .js to .tsx
2.Updating the JSDoc comment to reflect TypeScript typing conventions
3.Maintaining all existing functionality without any behavioral changes
Areas of Impact
File affected:
src/client/components/pages/registration-auth.js→src/client/components/pages/registration-auth.tsx