Skip to content

Fix: replace Button with anchor tag in EntityAnnotation toggle#1233

Open
garvthakre wants to merge 1 commit intometabrainz:masterfrom
garvthakre:fix/annotation-show-more-button
Open

Fix: replace Button with anchor tag in EntityAnnotation toggle#1233
garvthakre wants to merge 1 commit intometabrainz:masterfrom
garvthakre:fix/annotation-show-more-button

Conversation

@garvthakre
Copy link
Contributor

@garvthakre garvthakre commented Feb 19, 2026

Problem

Related ticket: BB-869
This ticket has two issues:

1.Long annotations getting cut halfway through ,this is already fixed on the live site and locally.
2.The "Show more/less" toggle using a Bootstrap Button component ,this is still unfixed.

Solution

1.Replaced the Bootstrap Button component with a plain tag with role="button" for better semantics and accessibility.
2.Added e.preventDefault() to prevent the default anchor scroll behavior.
3.Removed the now-unused Button import.

Areas of Impact

src/client/components/pages/entities/annotation.js

@garvthakre
Copy link
Contributor Author

Hey @MonkeyDo, could you take a look when you get a chance? It's a small change ,just replacing a Bootstrap Button with a plain tag in the annotation toggle. Should be a quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments