Fix: replace Button with anchor tag in EntityAnnotation toggle#1233
Open
garvthakre wants to merge 1 commit intometabrainz:masterfrom
Open
Fix: replace Button with anchor tag in EntityAnnotation toggle#1233garvthakre wants to merge 1 commit intometabrainz:masterfrom
garvthakre wants to merge 1 commit intometabrainz:masterfrom
Conversation
Contributor
Author
|
Hey @MonkeyDo, could you take a look when you get a chance? It's a small change ,just replacing a Bootstrap Button with a plain tag in the annotation toggle. Should be a quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Related ticket: BB-869
This ticket has two issues:
1.Long annotations getting cut halfway through ,this is already fixed on the live site and locally.
2.The "Show more/less" toggle using a Bootstrap Button component ,this is still unfixed.
Solution
1.Replaced the Bootstrap Button component with a plain tag with role="button" for better semantics and accessibility.
2.Added e.preventDefault() to prevent the default anchor scroll behavior.
3.Removed the now-unused Button import.
Areas of Impact
src/client/components/pages/entities/annotation.js