Open
Conversation
Getting node version error starting today with getong/elasticsearch-action@v1.2 v1.3 is available and could maybe fix, but we might as well try the official ES action
A long time coming...
to fix some types pollutions issue
+ add TS types + cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a looooong time coming upgrade of the Elasticsearch server from version 5.x (!) to 9.x
There were quite a few major changes that needed to happen during that upgrade, changing mappings and settings, as well as filtering by entity type (native type removed in ES 6.x)
I tried to keep search functionality as close as possible to what we have in production while profiting from performance improvements.
While in there I took the opportunity to improve typing, and update chai-http as a side effect (the chai-http types were polluting types on a global scope)