MBS-14273 (1/3): Run second CI tests with Perl 5.42.0#3728
Draft
yvanzo wants to merge 15 commits intometabrainz:masterfrom
Draft
MBS-14273 (1/3): Run second CI tests with Perl 5.42.0#3728yvanzo wants to merge 15 commits intometabrainz:masterfrom
yvanzo wants to merge 15 commits intometabrainz:masterfrom
Conversation
e90dc21 to
236038d
Compare
236038d to
c52c4f3
Compare
The new file `cpanfile-second` will be adapted in the next commits. The ultimate goal is to add CI tests with a second Perl setup. Reference: https://tickets.metabrainz.org/browse/MBS-14273
The content was copied from `cpanfile` in previous commit. See MBS-14243 for the reasons to pick up Perl version 5.42.0. The ultimate goal is to add CI tests with a second Perl setup. Reference: https://tickets.metabrainz.org/browse/MBS-14273
The new file `cpanfile.snapshot-second` will be regenerated later on. The ultimate goal is to add CI tests with a second Perl setup.
The new macro `set_second_perl_install_args` is adapted from the above macro `set_perl_install_args`. See MBS-14243 for the reasons to pick up Perl version 5.42.0. The ultimate goal is to add CI tests with a second Perl setup. Reference: https://tickets.metabrainz.org/browse/MBS-14273
The new `Dockerfile.second-tests.m4` will be adapted in the next commit. Also update the `Makefile` to take the new template into account. The ultimate goal is to add CI tests with a second Perl setup.
The content was copied from `Dockerfile.tests.m4` in previous commit. The new template file does build tests image with a second Perl setup. The ultimate goal is to add CI tests with a second Perl setup.
This new CI tag `SECOND_PERL_VERSION` will be used in later commits to add CI tests with a second Perl setup.
The new `build-second-tests-image` will be adapted in the next commit. The ultimate goal is to add CI tests with a second Perl setup.
The content was copied from `build-tests-image` in previous commit. The new CI job does build tests image with a second Perl setup. The ultimate goal is to add CI tests with a second Perl setup.
The new `second-js-perl-and-pgtap` will be adapted in the next commit. The ultimate goal is to add CI tests with a second Perl setup.
The content was copied from `js-perl-and-pgtap` in previous commit. The new CI job does run JS/Perl/pgTAP tests with a second Perl setup. The ultimate goal is to run all CI tests with a second Perl setup.
The new `second-selenium` will be adapted in the next commit. The ultimate goal is to run all CI tests with a second Perl setup.
The content was copied from `selenium` in previous commit. The new CI job does run Selenium tests with a second Perl setup. The ultimate goal is to run all CI tests with a second Perl setup.
The new `second-generate-reports` will be adapted in the next commit. The ultimate goal is to run all CI tests with a second Perl setup.
The content was copied from `generate-reports` in previous commit. The issue was that artifacts could not be reached from other container. The new CI job does generate reports from jobs with a second Perl setup.
c52c4f3 to
f4f8cad
Compare
Member
|
Looks great overall though I didn't have time to thoroughly review the PR today, only noticed that the final second-generate-reports job is failing. My guess (only a guess) is that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MBS-14243 is about upgrading the version of Perl from 5.38 (in production) to 5.42 to follow supported versions. It is planned for deployment with the next MusicBrainz database schema change in May 2026.
In the meantime, MBS-14273 is about making this upgrade available for development. So the MBS code should be tested with both versions of Perl until May schema change release.
Solution
Draft progress
cpanfile-secondand its snapshotFurther action
The production upgrade MBS-14243 will be deployed with the May schema change release.