MBS-14272: Don't block OTOTOY interviews#3729
Open
reosarevok wants to merge 1 commit intometabrainz:masterfrom
Open
MBS-14272: Don't block OTOTOY interviews#3729reosarevok wants to merge 1 commit intometabrainz:masterfrom
reosarevok wants to merge 1 commit intometabrainz:masterfrom
Conversation
From its website: "OTOTOY is a hi-res music store and also brings you the music news, reviews and interviews" So far, we were only allowing for downloadpurchase for any entity types that have that, meaning that while reviews were not blocked (because RG has no purchase option), artist interviews were. Rather than trying to guess the right type for /feature links (probably mostly reviews for RGs and interviews for artists, but are they always?) I am playing it safe and just excluding /feature links entirely from the autoselection mechanism. This will mean they don't get cleaned up to https, but that is their site default anyway so it shouldn't cause many issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MBS-14272
Problem
From its website: "OTOTOY is a hi-res music store and also brings you the music news, reviews and interviews" So far, we were only allowing for
downloadpurchasefor any entity types that have that, meaning that while reviews were not blocked (because RG has no purchase option), artist interviews were. Those links all look likehttps://ototoy.jp/feature/[0-9]+.Solution
Rather than trying to guess the right type for
/featurelinks (probably mostly reviews for RGs andinterviews for artists, but are they always?) I am playing it safe and just excluding
/featurelinks entirely from the autoselection mechanism.This will mean they don't get cleaned up to
https, but that is their site default anyway so it shouldn't cause many issues.AI usage
None
Testing
Manually. I don't think we have a way to specifically test that a link is skipped (rather than allowed or blocked) by the system, but if I'm forgetting it and we do, let me know and I can add a test.