MBS-14279: Support Amazon Belgium links#3732
Merged
reosarevok merged 1 commit intometabrainz:masterfrom Mar 3, 2026
Merged
Conversation
Member
|
Apparently You can fix those test failures by adding |
There seem to be no Amazon Music Belgium pages, so not supporting those. Amusingly, apparently Amazon probably couldn't get amazon.be for a decent price, so they went for amazon.com.be - it seems that com.be is not a valid public suffix for Belgium, but a private domain Amazon probably owns. As such, we need to have amazon.com.be separately in the hostname options, since the hostname is not seen by amazon.*.
Member
Author
|
Thanks! I wouldn't have thought of that being an option 😅 |
mwiencek
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement MBS-14279
Description
Amazon Belgium links are not handled as Amazon links at all at the moment. This just adds
com.beas one of the supported domains that make proper and expected Amazon pages.AI usage
None
Testing
Added a test (which for some reason seems to be failing locally - what am I missing?)