-
-
Notifications
You must be signed in to change notification settings - Fork 421
PICARD-442: Add match quality column and allow sorting #2696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PICARD-442: Add match quality column and allow sorting #2696
Conversation
FYI.. changes unrelated to the feature is due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine to me.
For clarification, I assume this new column is intended to augment (not replace) the current Album / Release status icon. In that case, it might be better positioned in a column adjacent to the current Album / Release status icon.
My other concern is with the width of this column -- always a minimum of 200 pixels (if I read the code correctly). Since the details are available for display as a tooltip on this new Match Quality icon, perhaps we can just display the icon and not the summary numbers (which can be viewed from the tooltip). This would save some of the limited available display space.
Finally, since this changes the standard display for the user, I believe that the documentation should be updated (at least the Album / Release Icons section, and possibly the images on the Main Screen page). I'll add a sub-task ticket for this so it doesn't get forgotten.
I think that would be my preference as well, since all the details are available via the tooltip.
That would help reduce the space required. Would it be possible to leave out the column name completely (and only have the sort direction indicator if required)? I'm thinking that it being next to the status icon might make it clear that it is the quality of the match. Then again, it might not be clear to other users. |
Mine too, as all infos are available elsewhere (tooltip and/or title). |
+1 for both of those from me, too |
This commit: 3f7260f
![]() |
Just tested on Linux and confirmed. The sorting order icon seems reversed on linux. Commit: 3039a01 |
@knguyen1 Overall the PR looks good, but UI wise there's likely few improvements we can make. Anyway, please resolve conflicts. |
I think the match column on the right works fine. But as zas pointed out it would be great if we could have no Match column, just the title, on the middle pane. |
3039a01
to
c6b5abb
Compare
…icard into feat/add-match-quality-column
Rebased and...
If you've previously tested the code with # line 421 of picard\ui\itemviews\basetreeview.py
self.restore_state() # <-- temporarily comment this out here ![]() |
Do we maybe need a migration that resets the column state? |
We don't in my opinion. It affects people (us devs) who had a col of 85px width there. It causes the Title col to shrink to 85px. |
Co-authored-by: Laurent Monin <[email protected]>
Okay can make it hideable. this commit: 7fae0ed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change missed, but the whole patch looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, code looks good and the match column is working great for me.
Summary
Problem
Users need a quick visual way to assess the quality of their file-to-track matches in albums. Currently, users must manually inspect each track to understand match status, which is time-consuming and error-prone.
Solution
MatchQualityColumn
class that displays match statistics at the album levelMatchQualityColumnDelegate
) for rendering icons and textAction
Additional actions required: