Skip to content
/ picard Public

PICARD-3235: fingerprint column shows both icon and text, and doesn't honor fixed size #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phw merged 2 commits into from
Mar 20, 2026
+21 −2
Merged

PICARD-3235: fingerprint column shows both icon and text, and doesn't honor fixed size #3100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
807faa0
PICARD-3235: do not display label in IconColumn header, set a tooltip…
zas Mar 19, 2026
2788250
Fix width of fixed columns when they lose the last column position
zas Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions picard/ui/itemviews/basetreeview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,10 @@
from picard.ui.columns import Columns
from picard.ui.enums import MainAction
from picard.ui.filter import Filter
from picard.ui.itemviews.custom_columns import DelegateColumn
from picard.ui.itemviews.custom_columns import (
DelegateColumn,
IconColumn,
)
from picard.ui.itemviews.custom_columns.shared import get_recognized_view_columns
from picard.ui.itemviews.events import header_events
from picard.ui.ratingwidget import RatingWidget
Expand Down Expand Up @@ -417,8 +420,19 @@ def _set_header_labels(self, update_column_count=False):
if isinstance(cols, Columns):
if update_column_count:
self.setColumnCount(len(cols))
labels = tuple(_(c.title) for c in cols)
labels = []
header_tooltips = {}
for i, c in enumerate(cols):
if isinstance(c, IconColumn):
labels.append('')
header_tooltips[i] = _(c.title)
else:
labels.append(_(c.title))
self.setHeaderLabels(labels)
if header_tooltips:
header_item = self.headerItem()
for i, tooltip in header_tooltips.items():
header_item.setToolTip(i, tooltip)

def restore_default_columns(self):
self._set_header_labels(update_column_count=False)
Expand Down Expand Up @@ -446,6 +460,11 @@ def _refresh_header_labels(self):
# reflect the actual visibility state, especially for newly added columns
header = self.header()
header.sync_visible_columns()
# Restore fixed size for non-resizeable columns, e.g. after being
# stretched by stretchLastSection when they were the last column.
for i, c in enumerate(self.columns):
if not c.resizeable and c.width is not None:
header.resizeSection(i, c.width)

def _refresh_all_items_data(self):
"""Refresh data for all items in the tree view."""
Expand Down
Loading