SEARCH-642 (indexer): Drop id fields for cdstub and tag#118
Draft
reosarevok wants to merge 3 commits intomasterfrom
Draft
SEARCH-642 (indexer): Drop id fields for cdstub and tag#118reosarevok wants to merge 3 commits intomasterfrom
reosarevok wants to merge 3 commits intomasterfrom
Conversation
1 task
Contributor
|
Just rebased on the latest |
yvanzo
reviewed
May 12, 2022
Contributor
There was a problem hiding this comment.
Since it is a breaking change that requires updating mbsssssat the same time, and thus a new release of mb-solr, I would prefer to merge this pull request and release the related MB Solr schema change separately from the MB Postgres schema change, so as not to further complicate our tests and deployment steps.
LGTMBDNT otherwise.
Contributor
|
It can’t be tested without getting metabrainz/mbsssss#59 ready, hence marked as draft. |
These are not the unique identifiers we use and are not exposed. For cdstub we expose unique discid, for tag unique name.
Run the following commands to regenerate SQL files:
python -m sir triggers -bid 2
./GenerateDropSql.pl
reosarevok
force-pushed
the
SEARCH-642
branch
from
dd32a60 to
0f66c9c
Compare
This updates tests to drop tag and cdstub IDs; since a key is expected, we use "tag" (the name) for tags and discid for cdstubs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SEARCH-642.
These are not the unique identifiers we use and are not exposed.
For cdstub we expose unique discid, for tag unique name.
Solution
This pull request stops filling this search field.
It also has to be removed it from search schema, see metabrainz/mbsssss#59
Checklist for author
Action
Deploy metabrainz/mbsssss#59
Deploy this pull request
Rebuild cdstub and tag search indexes