refactor: rename 'script' parameters to 'path' in file loading functions #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahdfady
reviewed
Oct 21, 2025
source/ports/rs_port/src/load.rs
Outdated
| let script_as_pathbuf = PathBuf::from(script.as_ref()); | ||
| for path in paths.into_iter() { | ||
| let script_as_pathbuf = PathBuf::from(path.as_ref()); | ||
| let script_as_str = script_as_pathbuf.to_str().unwrap(); |
There was a problem hiding this comment.
binding names like this are still irrelevant. script_as_str
There was a problem hiding this comment.
since I'm not so familiar with the functionality of this module I need to ask, should I rename all the variable names containing script or scripts to be path or paths ? or only inside the functions originally mentioned in the issue and their inline documentation (from_file, from single file) ?
There was a problem hiding this comment.
only from_file from single file 👍
…ath and paths respectively
fahdfady
reviewed
Oct 22, 2025
source/ports/rs_port/src/load.rs
Outdated
| } | ||
|
|
||
| c_script = cstring_enum!(script_as_str, MetaCallLoaderError)?; | ||
| c_script = cstring_enum!(path_as_str, MetaCallLoaderError)?; |
There was a problem hiding this comment.
we need this from c_script to c_path
There was a problem hiding this comment.
Sorry about that, I keep missing those 😅
…ath and paths respectively
fahdfady
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed the
scriptparameter topath(andscriptstopaths) in the Rust port’s file loading functions for better naming consistency and clarity.This change improves readability by making it clear that these functions load files from paths, not scripts in memory.
Fixes #586
Type of change
Checklist:
make clang-formatand verified my code follows style guidelines.