Adding test for HTML in integration.yml#108
Open
VanshikaSabharwal wants to merge 30 commits intometacall:masterfrom
Open
Adding test for HTML in integration.yml#108VanshikaSabharwal wants to merge 30 commits intometacall:masterfrom
integration.yml#108VanshikaSabharwal wants to merge 30 commits intometacall:masterfrom
Conversation
Contributor
Author
|
@fahdfady Please verify the content/logic, and then I will do the final cleanup to remove irrelevant code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:-
This PR primarily integrates proper HTML validation tests into the CI pipeline using Playwright, replacing the previously commented-out placeholder test logic.
Updated files
.github/workflows/integration.ymlPlaywright Integration (Main Change): Replaced the previously commented-out Playwright test block with a fully working implementation that:
PlaywrightandChromiumport 8080<title>, presence of#root div,main JSandCSS scriptreferences, and thelang="en"attributemacOS Fix: Split the previously combined Unix install step into separate Linux and macOS steps. Added explicit library path environment variables (
DYLD_LIBRARY_PATH,LD_LIBRARY_PATH,RUSTFLAGS) for macOS and a debug step to inspect the MetaCall installation. A solution has been identified and added (run proof), with the macOS build and integration tests now passing and being further refined — which is why the pipeline progresses successfully to the next stage.Link to the CI (where build and integration tests passes):-
https://github.com/VanshikaSabharwal/metassr/actions/runs/22988377852/job/66743756346
Link to working playwright test:-
https://github.com/VanshikaSabharwal/metassr/actions/runs/23040601286/job/66917882561
Image:-
PlaywrightandChromium