feat: init API system with new crate metassr-api-handler#67
Open
fahdfady wants to merge 8 commits intometacall:masterfrom
Open
feat: init API system with new crate metassr-api-handler#67fahdfady wants to merge 8 commits intometacall:masterfrom
metassr-api-handler#67fahdfady wants to merge 8 commits intometacall:masterfrom
Conversation
…l hello.js test Signed-off-by: Fahd Ashour <fahd.fady212@gmail.com>
hulxv
requested changes
Dec 22, 2025
| // This is a testing behavior that might change to use a dedicated | ||
| // MetaCall runtime thread for better async handling and isolation. | ||
| // Passing None as handle to use the global context. | ||
| load::from_memory(load::Tag::NodeJS, &code, None) |
Collaborator
There was a problem hiding this comment.
if we have multiple endpoints, the handler names will be duplicated (GET, POST, etc..). I think that will make metacall panics because it doesn't accept duplicated names
CC: @viferga
Collaborator
Author
hulxv
requested changes
Dec 22, 2025
Collaborator
hulxv
left a comment
There was a problem hiding this comment.
Dont miss resolving conflicts
hulxv
requested changes
Dec 22, 2025
Collaborator
hulxv
left a comment
There was a problem hiding this comment.
it seems you have an error
error[E0061]: this function takes 3 arguments but 2 arguments were supplied
--> crates/metassr-bundler/src/lib.rs:103:29
|
103 | if let Err(e) = load::from_memory(load::Tag::NodeJS, BUILD_SCRIPT) {
| ^^^^^^^^^^^^^^^^^--------------------------------- argument #3 of type `std::option::Option<&mut metacall::load::Handle>` is missing
|
note: function defined here
--> /home/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/metacall-0.5.6/src/load.rs:172:8
|
172 | pub fn from_memory(
| ^^^^^^^^^^^
help: provide the argument
|
103 | if let Err(e) = load::from_memory(load::Tag::NodeJS, BUILD_SCRIPT, /* std::option::Option<&mut metacall::load::Handle> */) {
|
…l hello.js test Signed-off-by: Fahd Ashour <fahd.fady212@gmail.com>
…into feat-api-handler
Collaborator
Author
Yeah my bad that was because of the conflicts. It should work now |
…t c_void between threads
…into feat-api-handler
Collaborator
|
What's the current status? Does it work as expected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #25