ci: replace deprecated GitHub Actions with modern equivalents#88
Closed
abhi0324 wants to merge 1 commit intometacall:masterfrom
Closed
ci: replace deprecated GitHub Actions with modern equivalents#88abhi0324 wants to merge 1 commit intometacall:masterfrom
abhi0324 wants to merge 1 commit intometacall:masterfrom
Conversation
fahdfady
reviewed
Mar 6, 2026
| profile: minimal | ||
| override: true | ||
| target: ${{ matrix.target }} | ||
| targets: ${{ matrix.target }} |
Collaborator
There was a problem hiding this comment.
you sure about target -> targets?
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
f912291 to
cfb01f2
Compare
Member
|
He's trying to inject malicious js into our repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
integration.ymlandrelease.ymluse several deprecated and unmaintained GitHub Actions that produce warnings on every CI run:actions-rs/toolchain@v1actions-rs/cargo@v1actions/checkout@v2actions/upload-artifact@v2Swatinem/rust-cache@v1Notably
lint.ymlalready usesdtolnay/rust-toolchain@stablecorrectly - this PR brings the other two workflows in line with it.Changes
integration.ymlactions-rs/toolchain@v1→dtolnay/rust-toolchain@stablerelease.ymlactions/checkout@v2→actions/checkout@v4actions-rs/toolchain@v1→dtolnay/rust-toolchain@stableSwatinem/rust-cache@v1→Swatinem/rust-cache@v2actions-rs/cargo@v1→ directcargo buildrun commandactions/upload-artifact@v2→actions/upload-artifact@v4Testing
integration.yml- runs automatically on this PR, results visible in the Actions tab above.release.yml- tag-only workflow, cannot be triggered by a PR. Changes are mechanical replacements verified against the already-working pattern inlint.yml, which usesdtolnay/rust-toolchain@stablesuccessfully.Notes
targets:parameter replacestarget:fordtolnay/rust-toolchainactions-rs/cargoreplaced with a directrun:step - the recommended approach that removes an unnecessary dependency