Skip to content

fix: properly ensure arrays size, avoid writing timestamp several times #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: properly ensure arrays size, avoid writing timestamp several times #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions measure/src/main/java/net/laprun/sustainability/power/measure/OngoingPowerMeasure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,18 @@ public SensorMetadata metadata() {

public void recordMeasure(double[] components) {
samples++;
ensureArraysSize();

final var timestamp = System.currentTimeMillis();
timestamps[samples - 1] = timestamp;

for (int component = 0; component < components.length; component++) {
final var componentValue = components[component];
// record that the value is not zero
if (componentValue != 0) {
nonZeroComponents.set(component);
}
recordComponentValue(component, componentValue, timestamp);
measures[component][samples - 1] = componentValue;
}

final var processors = processors();
Expand All @@ -78,8 +82,8 @@ public void recordMeasure(double[] components) {
}
}

private void recordComponentValue(int component, double value, long timestamp) {
final var currentSize = measures[component].length;
private void ensureArraysSize() {
final int currentSize = timestamps.length;
if (currentSize <= samples) {
final var newSize = currentSize * 2;
for (int index = 0; index < measures.length; index++) {
Expand All @@ -91,8 +95,6 @@ private void recordComponentValue(int component, double value, long timestamp) {
System.arraycopy(timestamps, 0, newTimestamps, 0, currentSize);
timestamps = newTimestamps;
}
timestamps[samples - 1] = timestamp;
measures[component][samples - 1] = value;
}

public Duration duration() {
Expand Down