Skip to content

Script/Tickets code cleanup #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Script/Tickets code cleanup #1295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a638c50
Script/Tickets code cleanup
mickeyn Oct 22, 2024
2f7ba1c
tidy
mickeyn Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cpanfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ requires 'IO::Prompt::Tiny';
requires 'IO::Uncompress::Bunzip2', '2.106';
requires 'IO::Zlib';
requires 'IPC::Run3', '0.048';
requires 'JSON::MaybeXS', '1.004004'; # indirect dep
requires 'List::Util', '1.62';
requires 'Log::Any::Adapter';
requires 'Log::Any::Adapter::Log4perl';
Expand Down
9 changes: 0 additions & 9 deletions lib/MetaCPAN/Script/Tickets.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ has rt_summary_url => (
default => 'https://rt.cpan.org/Public/bugs-per-dist.tsv',
);

has github_issues => (
is => 'ro',
required => 1,
default => 'https://api.github.com/repos/%s/%s/issues?per_page=100',
);

has github_token => (
is => 'ro',
lazy => 1,
Expand Down Expand Up @@ -117,8 +111,6 @@ sub index_github_bugs {

my %summary;

my $json = JSON::MaybeXS->new( allow_nonref => 1 );

RELEASE: while ( my $release = $scroll->next ) {
my $resources = $release->resources;
my ( $user, $repo, $source )
Expand Down Expand Up @@ -312,4 +304,3 @@ http://fastapi.metacpan.org/v1/distribution/Moose
http://fastapi.metacpan.org/v1/distribution/HTTP-BrowserDetect

=cut

5 changes: 0 additions & 5 deletions t/00_setup.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,11 +117,6 @@ ok(
scheme => 'file',
path => $fakecpan_dir->child('bugs.tsv')->absolute->stringify,
),
github_issues => uri(
scheme => 'file',
path => $fakecpan_dir->child('github')->absolute->stringify
. '/%s/%s.json?per_page=100'
),
} )->run,
'tickets'
);
Expand Down