update mappings to be compatible with elasticsearch 7 #1376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
force-pushed
the
haarg/es7-compat
branch
4 times, most recently
from
0f800c8 to
89401e9
Compare
oalders
previously approved these changes
May 2, 2025
The mapping script had options for doing a bunch of operations on Elasticsearch, such doing arbitrary creations or patches. This code often made a bunch of assumptions about how types worked. These types of operations are better done manually against the Elasticsearch APIs.
Elasticsearch 5 and newer has separate types for text and keywords rather than using the string type. Update our mappings to use these types, and add a compatibility shim to return the older style mappings when running 2.x.
oalders
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch 5 and newer has separate types for text and keywords rather than using the string type. Update our mappings to use these types, and add a compatibility shim to return the older style mappings when running 2.x.