remove special check for hidden packages #1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
previously approved these changes
Jul 13, 2025
haarg
force-pushed
the
haarg/no-special-package-parsing
branch
3 times, most recently
from
8fbe7b0 to
181d0e3
Compare
This simplifies converting to a JSON boolean.
The files listed in provides data should be an exact match for the file path we are using. The regex matching was added in f3543c1 saying only "fixed regression". I can barely guess at what it was supposedly fixing, but it was definitely not the correct fix.
Module::Metadata, Parse::PMFile, or provides metadata already tell us what modules exist in a file. They will not include packages hidden using the "hide from PAUSE" trick. This was possibly needed based on other metadata mishandling. Some of the tests were relying on this behavior and have been removed. They were expecting the data provided in the test to be overridden by the additional package check, but the module list would never have been given to them in our indexing code.
haarg
force-pushed
the
haarg/no-special-package-parsing
branch
from
181d0e3 to
08bd7ef
Compare
oalders
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module::Metadata and Parse::PMFile will already exclude modules using the 'hide from PAUSE' trick. There is no need to add an additional check on top of that.