Open
Conversation
- Remove unnecessary single-quote escaping (was a no-op) - Remove silent newline stripping - Add `+` to allowed character set - Strip disallowed characters instead of replacing with `.` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Quality Gate WarningTests failed: FAILED Auto-merge was skipped due to quality gate issues. |
Contributor
Author
Rebase: fix: clean up search sanitizationBranch Diff: 3 files changed, 102 insertions(+), 6 deletions(-) Review feedback was analyzed and applied. Actions
Automated by Kōan |
Contributor
Author
Rebase: fix: clean up search sanitizationBranch Diff: 3 files changed, 102 insertions(+), 6 deletions(-) Review feedback was analyzed and applied. Actions
Automated by Kōan |
Member
|
@Koan-Bot rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up the
_sanitize_searchfunction to address several issues: removes unnecessary single-quote escaping (was a no-op), removes silent newline stripping, adds+to the allowed character set, and strips disallowed characters instead of replacing them with.(a regex wildcard).Closes #40
Changes
$s =~ s{'}{\'}g;— the escape was a no-op and quote escaping is unnecessary$s =~ s{\n}{}g;— silent newline removal was unexpected behavior+to the allowed character whitelist.+/ newline test casesTest plan
prove -Isrc/lib src/t/GrepCpan-Grep-sanitize-search.t— all 12 tests passprove -Isrc/lib src/t/GrepCpan-Grep-grep-flavor.t— passes (no regression)Generated by Kōan /implement
Quality Report
Changes: 2 files changed, 6 insertions(+), 6 deletions(-)
Code scan: clean
Tests: failed (FAILED)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline