fix: use uri filter for URL params in templates#96
Draft
Koan-Bot wants to merge 1 commit intometacpan:masterfrom
Draft
fix: use uri filter for URL params in templates#96Koan-Bot wants to merge 1 commit intometacpan:masterfrom
Koan-Bot wants to merge 1 commit intometacpan:masterfrom
Conversation
show-ls.tt used html_entity for all URL query parameters and show-search.tt used it for qifl. html_entity encodes for HTML contexts (& → &) but doesn't percent-encode URL-unsafe characters like spaces, #, or +. This could break navigation links when search filters contain special characters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switches URL query parameter encoding from
html_entitytourifilter inshow-ls.ttandshow-search.tt.Why
html_entityencodes for HTML contexts (&→&,<→<) but doesn't percent-encode URL-unsafe characters like spaces,#,+, or=. When search filters contain these characters, the resulting URLs break — parameters get truncated or misinterpreted.show-search.ttalready usedurifor 4 of 5 params but missedqifl.show-ls.ttusedhtml_entityfor all 6 params plus the file link.How
show-ls.tt: all 6 query param variables +match.filein href →urishow-search.tt:qifl→uri(aligns with the other params)Other
html_entityuses in templates (form input values, HTML content, title attributes) are correct and unchanged.Testing
Verified all remaining
html_entityuses in.ttfiles are in HTML attribute/content contexts where they belong.🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 8 insertions(+), 8 deletions(-)
Code scan: clean
Tests: failed (FAILED)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline