fix scrolling to highlighted lines on source view #3271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3271 +/- ##
=======================================
Coverage 73.31% 73.31%
=======================================
Files 68 68
Lines 2387 2387
Branches 335 335
=======================================
Hits 1750 1750
Misses 509 509
Partials 128 128 |
getClientRects returns an array, and its values are relative to the viewport. scrollIntoView is much easier to use for this.
haarg
force-pushed
the
haarg/fix-source-scroll
branch
from
0ce5198 to
de4328b
Compare
mickeyn
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getClientRects returns an array, and its values are relative to the viewport. scrollIntoView is much easier to use for this.