Skip to content

Conversation

@oalders
Copy link
Member

@oalders oalders commented May 3, 2025

No description provided.

@oalders oalders requested a review from haarg May 3, 2025 18:17
Copy link
Member

@haarg haarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I had changed the exposed port to be 8000 is that macOS uses port 5000 by default for its own purposes. Technically it is still possible to listen on port 5000 on localhost, but this can get confusing. And obviously port 5001 is not the same and is not occupied, but I was hoping to get away from the 5000/5001 pairing we were using previously. I had missed that GitHub has the port 5001 hard coded in its dev app.

I'm fine with merging this if it makes things easier.

@oalders oalders added this pull request to the merge queue Jun 4, 2025
Merged via the queue into master with commit e8afe67 Jun 4, 2025
11 checks passed
@oalders oalders deleted the oalders/port branch June 4, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants