oalders/stars

[oalders]

• Add GitHub stars to favorite.tx

This can be tested via the url /release/OALDERS/HTML-Restrict-v3.0.2.

Note how badly styled it is. There's no need to keep anything from the current style.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.46%. Comparing base (1294326) to head (0d3fc52).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3341      +/-   ##
==========================================
+ Coverage   73.45%   73.46%   +0.01%     
==========================================
  Files          68       68              
  Lines        2388     2389       +1     
  Branches      335      335              
==========================================
+ Hits         1754     1755       +1     
  Misses        508      508              
  Partials      126      126              

Files with missing lines	Coverage Δ
lib/MetaCPAN/Web/Model/ReleaseInfo.pm	82.05% <100.00%> (+0.15%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[guest20]

Should the control disappear when there are zero stars?

[oalders]

That was my original thought, but now I'm not sure.

[JordanEdward02]

Tried to make it match the favourites button as much as I could, but obviously couldn't go with orange background because the contrast with the star is awful. Please let me know if you think any changes are needed :)

[guest20]

Perhaps there should be a github icon in the area to indicate that they are github stars?

Also, when talking about github stars the yellow/full star means you, yourself have starred it:

This is what the control on github looks like when you haven't starred the thing yourself:

[oalders]

Tried to make it match the favourites button as much as I could, but obviously couldn't go with orange background because the contrast with the star is awful.

Thanks for this! For some reason I missed the notification until now.

Perhaps there should be a github icon in the area to indicate that they are github stars?

I think there is a font-awesome GitHub icon we could add to this.

Also, when talking about github stars the yellow/full star means you, yourself have starred it

We don't have a good way of knowing if the user has starred the repo or not, so I don't know that there is a perfect solution here.