feat: binary trace format version 1 and trace stream writing support #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… takes path and format parameters
…t parameters in its initializer, and then pass it to the Rust native recorder
…ake parameters, since the out_dir and format are now passed to initialize (in order to support stream writing)
…ce to more closely match the Rust-based recorder, by moving the out_dir parameter to the initialize method, instead of flush_trace
…t (because it's still supported by the runtime_tracing library)
…stead of doing it manually
…stead of doing it manually (yet again...)
…ly (there's a pattern of sloppy code here...)
Benchmark Report
|
alehander92
reviewed
Aug 4, 2025
alehander92
reviewed
Aug 4, 2025
alehander92
approved these changes
Aug 4, 2025
Member
alehander92
left a comment
alehander92
left a comment
There was a problem hiding this comment.
looks very good to me, just small nitpicks
i think the windows problem can be left for when we go back to finishing windows support for codetracer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.