Open
Conversation
Fix native recorder loading and debug printing. Update gem installation scripts to use new classes and add '--' separator test.
The gem installation tests were skipped due to a conditional bug that tested a string literal instead of the variable. This caused the library script to always use the PureRuby recorder and fail when running the native gem. Removed the skip and corrected the gem_bin check so the proper recorder class is chosen when generating the temporary script.
Avoid capturing the tracer object itself when preparing argument records and disable tracepoints while recording Kernel event hooks. Ensure patches remove aliases when uninstalled and update gem installation test script.
zah
force-pushed
the
refactor-gems
branch
2 times, most recently
from
c341068 to
a449fd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PureRubyRecorderfrom tracing itself when preparing argumentsTesting
timeout 100s just testhttps://chatgpt.com/codex/tasks/task_e_683a9605bb808329bcc08e1db70c7fab