Skip to content

Update rb_raise error handling #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025
Merged

Update rb_raise error handling #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .agents/tasks/2025/06/29-2309-cstring-error
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Create CString objects for error strings before passing them to rb_raise
18 changes: 12 additions & 6 deletions gems/codetracer-ruby-recorder/ext/native_tracer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,18 +685,24 @@ unsafe extern "C" fn flush_trace(self_val: VALUE, out_dir: VALUE, format: VALUE)
match std::str::from_utf8(slice) {
Ok(path_str) => {
if let Err(e) = flush_to_dir(&recorder.tracer, Path::new(path_str), fmt) {
let msg = std::ffi::CString::new(e.to_string())
.unwrap_or_else(|_| std::ffi::CString::new("unknown error").unwrap());
rb_raise(
rb_eIOError,
b"Failed to flush trace: %s\0".as_ptr() as *const c_char,
e.to_string().as_ptr() as *const c_char,
msg.as_ptr(),
);
}
}
Err(e) => rb_raise(
rb_eIOError,
b"Invalid UTF-8 in path: %s\0".as_ptr() as *const c_char,
e.to_string().as_ptr() as *const c_char,
),
Err(e) => {
let msg = std::ffi::CString::new(e.to_string())
.unwrap_or_else(|_| std::ffi::CString::new("invalid utf8").unwrap());
rb_raise(
rb_eIOError,
b"Invalid UTF-8 in path: %s\0".as_ptr() as *const c_char,
msg.as_ptr(),
)
},
}

Qnil.into()
Expand Down
Loading