Skip to content

feat: Implement upload/download of trace records#22

Merged
alehander92 merged 34 commits intomainfrom
feat-upload-download-traces
Mar 17, 2025
Merged

feat: Implement upload/download of trace records#22
alehander92 merged 34 commits intomainfrom
feat-upload-download-traces

Conversation

@pxor
Copy link
Contributor

@pxor pxor commented Mar 4, 2025

internal support for trace sharing, graphical interface for them and implementing underlying ct download <download-key> / ct upload commands.

some screenshots:

recent traces:

image

graphical interface for opening download links

image

@pxor pxor added the enhancement New feature or request label Mar 4, 2025
@pxor pxor requested a review from alehander92 March 4, 2025 16:35
@pxor pxor self-assigned this Mar 4, 2025
@cla-bot cla-bot bot added the cla-signed label Mar 4, 2025
@pxor pxor marked this pull request as draft March 4, 2025 16:35
@pxor pxor force-pushed the feat-upload-download-traces branch 3 times, most recently from f838285 to b8a295a Compare March 11, 2025 11:46
@Madman10K Madman10K self-requested a review March 11, 2025 12:04
Copy link
Contributor

@Madman10K Madman10K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just needs to be changed to follow the common code style. Maybe @alehander92 can add to the review

@pxor pxor changed the title WIP: Implement upload/download of trace records feat: Implement upload/download of trace records Mar 13, 2025
@pxor pxor marked this pull request as ready for review March 13, 2025 14:40
@alehander92 alehander92 added the frontend Any issues regarding the GUI frontend label Mar 13, 2025
@pxor pxor force-pushed the feat-upload-download-traces branch 2 times, most recently from a0bfe93 to d62665f Compare March 14, 2025 15:42
@pxor
Copy link
Contributor Author

pxor commented Mar 14, 2025

image

@pxor
Copy link
Contributor Author

pxor commented Mar 14, 2025

image

Copy link
Contributor

@alehander92 alehander92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, a few changes left!

@pxor pxor force-pushed the feat-upload-download-traces branch 2 times, most recently from 3970d59 to 22744e3 Compare March 17, 2025 10:01
pxor added 6 commits March 17, 2025 12:23
Currently there is a GUI for the upload button
When clicked, it zips the given trace with a random password encryption
and uploads it to the provided web api root
In the nim-lan/zip library password encryption is not supported
so we are currently using the standard zip and unzip packages
Still need to encrypt the file and set up the codetracer web api
pxor added 23 commits March 17, 2025 12:23
…ding on the trace fields

Add fields for the downloadKey, controlId and expireTime to the trace object
Add a Command for delete of trace files
Handle deleting of the trace file's download key, controlId and expireTime
…nished and handle the frontend update of the trace object
…get upload/delete/download links for ease of use
@pxor pxor force-pushed the feat-upload-download-traces branch from 22744e3 to 664eb69 Compare March 17, 2025 10:23
@alehander92 alehander92 merged commit 1f9b620 into main Mar 17, 2025
13 checks passed
@alehander92 alehander92 deleted the feat-upload-download-traces branch March 17, 2025 13:22
@alehander92 alehander92 added trace sharing cli Issues related to the CLI interface labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed cli Issues related to the CLI interface enhancement New feature or request frontend Any issues regarding the GUI frontend trace sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants