Split codetracer.nim into multiple files and remove orphaned functions#24
Merged
alehander92 merged 3 commits intomainfrom Mar 10, 2025
Merged
Split codetracer.nim into multiple files and remove orphaned functions#24alehander92 merged 3 commits intomainfrom
alehander92 merged 3 commits intomainfrom
Conversation
…s, removed obsolete functionality and added some Windows code
Madman10K
added
documentation
alehander92
reviewed
Mar 10, 2025
alehander92
reviewed
Mar 10, 2025
alehander92
reviewed
Mar 10, 2025
alehander92
reviewed
Mar 10, 2025
alehander92
reviewed
Mar 10, 2025
alehander92
suggested changes
Mar 10, 2025
Contributor
alehander92
left a comment
alehander92
left a comment
There was a problem hiding this comment.
look good: we discussed/looked at most of the changes them privately before opening the PR, so I agree with most of the refactoring; additional improvements and fixes might be part of new PR-s; several small things to fix required
…s and move startCore to backends
alehander92
approved these changes
Mar 10, 2025
Contributor
alehander92
left a comment
alehander92
left a comment
There was a problem hiding this comment.
great, looks much better after the refactoring!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start of a movement to refactor the way codetracer is launched. This PR splits the current monolithic
codetracer.nimfile into 17 files and removes a number of orphaned functions along the way.A further functional refactor can be done in a followup PR, since there is a lot to untangle. This PR should make this process significantly easier though!
It also adds on the documentation, adding all environment variables that are exposed by
codetracer.nim