Open
Conversation
- document MemoryView layout, virtualization, and highlight behavior - outline implementation plan with frontend/backend/DAP integration steps
- add shared MemoryView types and event kinds - wire DAP mapping + middleware and add db-backend handlers
- add base64 dependency and limit placeholder range size - return zero-filled bytes with defensive validation
- add handler test for load-memory-range response - verify base64 zero-fill payload
- register MemoryView content/action and default layout tab - render placeholder grid and request memory range
- add MemoryView styles and placeholder grid layout - add highlight button next to history toggle
alehander92
added
documentation
- include size in Variable/VariableWithRecord payloads - populate placeholder size in db locals response
- add size to locals and wire into ValueComponent - use address + size when highlighting
- treat NO_ADDRESS as 0 for memory view highlights
alehander92
force-pushed
the
fix-bugs-and-styling-01
branch
2 times, most recently
from
71110d8 to
fa78e86
Compare
pxor
force-pushed
the
fix-bugs-and-styling-01
branch
from
fa78e86 to
a14a1be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for now with hardcoded zero-s in db : requires TODO ct-rr-support loading memory view query impl