Verify perf #4
Verify perf #4
Conversation
smanilov
left a comment
smanilov
left a comment
There was a problem hiding this comment.
Preliminary review; interrupted by other tasks.
| if args.input_file.is_empty() { | ||
| eprintln!("No file name provided after '--input-file'."); | ||
| std::process::exit(1); | ||
| } |
There was a problem hiding this comment.
This check will be triggered only if someone passes an empty string as the file name.
Clap has checks for missing flags included, so you could just remove this, unless you want exactly this behavior (to catch --input-file "").
# ./target/release/dvt_prover_host --input-file
error: a value is required for '--input-file <INPUT_FILE>' but none was supplied
For more information, try '--help'.
# ./target/release/dvt_prover_host --input-file "" --type share
No file name provided after '--input-file'.
src/main.rs
Outdated
|
|
||
| fn read_text_file(filename: &str) -> Result<String, Box<dyn Error>> { | ||
| fn read_text_file(filename: &str) -> Result<String, Box<dyn Error>> { | ||
| let mut file = File::open(filename).map_err(|e| format!("Error opening file: {}", e))?; |
There was a problem hiding this comment.
The error currently looks like this:
# ./target/release/dvt_prover_host --input-file examples/dvt_bad_share.json --type share --json-schema-file foo
Error opening file: No such file or directory (os error 2)
In my opinion, this is a shortcoming of std::io: the name of the file is not printed. I would add it in the error message manually:
let mut file = File::open(filename).map_err(|e| format!("Error opening file {filename}: {e}"))?;Also, note that you can interpolate variables directly. (But not expressions; format!("{x}"); works, but format!("{call_me()}"); does not.)
There was a problem hiding this comment.
I don't see this change in the current code. Did you forget to add it?
There was a problem hiding this comment.
now should be there
smanilov
left a comment
smanilov
left a comment
There was a problem hiding this comment.
Finished review of the share_exchange_prove guest program.
Let me know if you would like me to review more of this code (the other guest programs).
No description provided.