feat(mcl/host_info): Upload results to Coda #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilIvanichkovv
approved these changes
Jun 20, 2024
monyarm
force-pushed
the
feat/machine_create
branch
from
00b941d to
8c7b681
Compare
PetarKirov
force-pushed
the
feat/CD
branch
3 times, most recently
from
b5368a3 to
fcf842e
Compare
monyarm
force-pushed
the
feat/machine_create
branch
12 times, most recently
from
66797ca to
b9b7a6c
Compare
monyarm
force-pushed
the
feat/machine_create
branch
from
262859d to
f00425a
Compare
Contributor
|
Thanks for your Pull Request! Below you will find a summary of the cachix status of each package, for each supported platform.
|
PetarKirov
requested changes
Apr 10, 2025
| import std.array : join; | ||
| import std.algorithm : map; | ||
| import std.conv : to; | ||
| import std.stdio : writeln; |
Collaborator
There was a problem hiding this comment.
Looks like this line is unused:
Suggested change
| import std.stdio : writeln; |
| coda.deleteRow("dEJJPwdxcw", tables[0].id, resp[0]); | ||
| } | ||
|
|
||
| void updateOrInsertRow(string docId, string tableId, RowValues values) { |
Collaborator
There was a problem hiding this comment.
According to the Coda Api docs, we should be able to directly create an "Upsert" request, without first fetching the data:
https://coda.io/developers/apis/v1#tag/Rows/operation/upsertRows
Can you look into directly doing an upsert?
| info.hardwareInfo.displayInfo = getDisplayInfo(); | ||
| info.hardwareInfo.graphicsProcessorInfo = getGraphicsProcessorInfo(); | ||
|
|
||
| if (params.codaApiToken) { |
Collaborator
There was a problem hiding this comment.
Inform the user of this conditional behavior by logging:
- No Coda API token specified -> not uploading to Coda
- Coda API token specified -> uploading
(feed free to rephrase the messages)
| { | ||
| } | ||
| } | ||
| Params params; |
Collaborator
There was a problem hiding this comment.
Avoid global variables, as they make the control flow harder to reason about as the codebase evolves.
| export void host_info() | ||
| { | ||
| const params = parseEnv!Params; | ||
| params = parseEnv!Params; |
Collaborator
There was a problem hiding this comment.
This should remain a local const variable. If necessary add parameters to the functions that need to access it.
| folder-size-metrics = pkgs.callPackage ./folder-size-metrics { }; | ||
| } | ||
| // optionalAttrs (system == "x86_64-linux") { | ||
| // optionalAttrs (system == "x86_64-linux") rec { |
Collaborator
There was a problem hiding this comment.
I don't think we need to make this attrset recursive:
Suggested change
| // optionalAttrs (system == "x86_64-linux") rec { | |
| // optionalAttrs (system == "x86_64-linux") { |
| import mcl.utils.number : humanReadableSize; | ||
| import mcl.utils.array : uniqIfSame; | ||
| import mcl.utils.nix : Literal; | ||
| import mcl.utils.coda; |
Collaborator
There was a problem hiding this comment.
Use selective imports:
Suggested change
| import mcl.utils.coda; | |
| import mcl.utils.coda : CodaApiClient, RowValues, CodaCell; |
PetarKirov
added a commit
that referenced
this pull request
Apr 10, 2025
Co-authored-by: Petar Kirov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.