update resourcelanguage from code to text #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ianwallen
reviewed
Oct 25, 2021
Contributor
ianwallen
left a comment
ianwallen
left a comment
There was a problem hiding this comment.
Anglaise should be Anglais
src/main/config/codelist/local/thesauri/theme/GC_Resource_Languages.rdf
Outdated
Show resolved
Hide resolved
src/main/config/codelist/local/thesauri/theme/GC_Resource_Languages.rdf
Outdated
Show resolved
Hide resolved
ianwallen
reviewed
Oct 25, 2021
ianwallen
reviewed
Oct 27, 2021
Contributor
ianwallen
left a comment
ianwallen
left a comment
There was a problem hiding this comment.
Changes look good however based on the following comment
We are not getting the results that are expected.
So we have to wait until the issues identified in that comment are resolved before we can approve this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource language currents is using code instead of actual text as label. Here is the updated view from the user.