Skip to content

Commit 2035cab

Browse files
committed
Script: Close script file resources.
1 parent f353d93 commit 2035cab

File tree

1 file changed

+6
-5
lines changed
  • metamorph/src/main/java/org/metafacture/metamorph/functions

1 file changed

+6
-5
lines changed

metamorph/src/main/java/org/metafacture/metamorph/functions/Script.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
import org.metafacture.metamorph.api.MorphExecutionException;
2222
import org.metafacture.metamorph.api.helpers.AbstractSimpleStatelessFunction;
2323

24-
import java.io.FileNotFoundException;
24+
import java.io.IOException;
25+
import java.io.Reader;
2526
import javax.script.Invocable;
2627
import javax.script.ScriptEngine;
2728
import javax.script.ScriptEngineManager;
@@ -60,14 +61,14 @@ public void setInvoke(final String invoke) {
6061
public void setFile(final String file) {
6162
final ScriptEngineManager manager = new ScriptEngineManager();
6263
final ScriptEngine engine = manager.getEngineByName("JavaScript");
63-
try {
64-
// TODO: The script file should be loaded relatively to the base URI
65-
engine.eval(ResourceUtil.getReader(file));
64+
// TODO: The script file should be loaded relatively to the base URI
65+
try (Reader reader = ResourceUtil.getReader(file)) {
66+
engine.eval(reader);
6667
}
6768
catch (final ScriptException e) {
6869
throw new MorphBuildException("Error in script", e);
6970
}
70-
catch (final FileNotFoundException e) {
71+
catch (final IOException e) {
7172
throw new MorphBuildException("Error loading script '" + file + "'", e);
7273
}
7374
invocable = (Invocable) engine;

0 commit comments

Comments
 (0)