Make deploys independent of build artifact

[dipamsen]

Description

Deploy for PR #89 failed because the existing workflows for build and deploy were dependent, the build-ci-test workflow (which runs on PRs) generated a build artifact, which then was downloaded by the deploy-gh-pages workflow, when it ran (on push). However in the above case, the deploy workflow could not download the artifact, since the build workflow ran on a fork of the repo, not the main repo itself.

This PR changes the workflows to not upload/download artifact, and instead perform repeated builds, once in the build-ci-test workflow, and once more in the deploy-gh-pages workflow.

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[proffapt]

Hmm, makes sense I never cloned the repo.