Skip to content

By accident machine-allocation-type was optional #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majst01 merged 1 commit into from
Aug 11, 2025
Merged

By accident machine-allocation-type was optional #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14663,7 +14663,7 @@ <h3 id="metalstack.api.v2.MachineAllocation">MachineAllocation</h3>
<tr>
<td>allocation_type</td>
<td><a href="#metalstack.api.v2.MachineAllocationType">MachineAllocationType</a></td>
<td>optional</td>
<td></td>
<td><p>AllocationType of this machine </p></td>
</tr>

Expand Down Expand Up @@ -15762,7 +15762,7 @@ <h3 id="metalstack.api.v2.MachineServiceCreateRequest">MachineServiceCreateReque
<tr>
<td>allocation_type</td>
<td><a href="#metalstack.api.v2.MachineAllocationType">MachineAllocationType</a></td>
<td>optional</td>
<td></td>
<td><p>AllocationType of this machine </p></td>
</tr>

Expand Down
31 changes: 14 additions & 17 deletions go/metalstack/api/v2/machine.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions proto/metalstack/api/v2/machine.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ message MachineServiceCreateRequest {
// NTPServer the ntp servers used for the machine
repeated NTPServer ntp_server = 17 [(buf.validate.field).repeated.max_items = 10];
// AllocationType of this machine
optional MachineAllocationType allocation_type = 18 [(buf.validate.field).enum.defined_only = true];
MachineAllocationType allocation_type = 18 [(buf.validate.field).enum.defined_only = true];
// FirewallRules to be applied if this is a firewall
FirewallRules firewall_rules = 19;
}
Expand Down Expand Up @@ -290,7 +290,7 @@ message MachineAllocation {
// AWS limits the max userdata size to 16k, lets allow twice as much
string userdata = 12 [(buf.validate.field).string = {max_len: 32768}];
// AllocationType of this machine
optional MachineAllocationType allocation_type = 13 [(buf.validate.field).enum.defined_only = true];
MachineAllocationType allocation_type = 13 [(buf.validate.field).enum.defined_only = true];
// FirewallRules to be applied if this is a firewall
FirewallRules firewall_rules = 14;
// DNSServers for this machine
Expand Down
Loading
Loading