Skip to content

Managed Node Network ID#119

Merged
vknabel merged 3 commits intomainfrom
feature-optional-node-network
Jan 9, 2026
Merged

Managed Node Network ID#119
vknabel merged 3 commits intomainfrom
feature-optional-node-network

Conversation

@vknabel
Copy link
Contributor

@vknabel vknabel commented Nov 24, 2025 •
edited
Loading

Description

As starting with #118 firewalls can now be managed by cluster api, the node network ID isn't necessarily required anymore.

Essentially this PR reverts #55 and updates the tests and templates accordingly.

Here we will fully manage the node network id which also includes its deletion.

References:

Release Notes

Noteworthy

The `MetalStackCluster.spec.nodeNetworkID` is now optional and managed by CAPMS. When deleting a cluster, the node network will now also be deleted.

@vknabel vknabel added minor Breaking change or new feature, causes the release drafter to create a new minor version area: cluster-api Affects the cluster-api area. labels Nov 24, 2025
@vknabel vknabel force-pushed the feature-optional-node-network branch from e833592 to 4587bc6 Compare November 24, 2025 11:02
@vknabel vknabel changed the base branch from main to feature-simplified-firewalls November 24, 2025 11:03
@vknabel vknabel changed the base branch from feature-simplified-firewalls to main November 24, 2025 11:03
@vknabel vknabel force-pushed the feature-optional-node-network branch from 4587bc6 to 87ca073 Compare November 24, 2025 11:10
@vknabel vknabel changed the base branch from main to feature-simplified-firewalls November 24, 2025 11:13
@vknabel vknabel changed the base branch from feature-simplified-firewalls to main November 24, 2025 11:14
@vknabel vknabel force-pushed the feature-optional-node-network branch from 87ca073 to f0a1815 Compare November 26, 2025 08:26
@vknabel vknabel requested a review from Gerrit91 November 26, 2025 08:27
@vknabel vknabel marked this pull request as ready for review November 26, 2025 08:27
@vknabel vknabel removed the minor Breaking change or new feature, causes the release drafter to create a new minor version label Nov 26, 2025
@vknabel vknabel force-pushed the feature-optional-node-network branch from f0a1815 to bc8153c Compare November 26, 2025 13:12
@Gerrit91 Gerrit91 added the triage This should be talked about in the next planning. label Dec 1, 2025
@Gerrit91 Gerrit91 moved this to In Progress in Development Dec 1, 2025
@metal-robot metal-robot bot removed the triage This should be talked about in the next planning. label Dec 1, 2025
simcod
simcod reviewed Dec 23, 2025
View reviewed changes
@vknabel vknabel force-pushed the feature-optional-node-network branch from bc8153c to eaa328e Compare January 7, 2026 08:54
@vknabel vknabel force-pushed the feature-optional-node-network branch from eaa328e to b78ec24 Compare January 8, 2026 12:25
@vknabel vknabel requested a review from simcod January 8, 2026 13:26
@vknabel vknabel mentioned this pull request Jan 9, 2026
Closed
@vknabel vknabel merged commit 701c7dd into main Jan 9, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Jan 9, 2026
@simcod simcod deleted the feature-optional-node-network branch January 9, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simcod simcod simcod approved these changes

@Gerrit91 Gerrit91 Awaiting requested review from Gerrit91

Assignees

No one assigned

Labels

area: cluster-api Affects the cluster-api area.

Projects

Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vknabel @simcod @Gerrit91