Skip to content

Integrate metal-ccm. #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robertvolkmann merged 12 commits into from
Jan 28, 2025
Merged

Integrate metal-ccm. #48

robertvolkmann merged 12 commits into from
Jan 28, 2025

Conversation

@Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Jan 23, 2025

Description

Closes #16.

@Gerrit91
Copy link
Contributor Author

Gerrit91 commented Jan 23, 2025

For now this does only provide instance metadata, the load balancer reconcile just fails because it assumes MetalLB to be present:

cloud-controller-manager-67cf5489b7-4hwr9 cloud-controller-manager E0123 14:05:13.415474       1 ticker.go:29] load balancer syncher failed: error updating load balancer config: no matches for kind "BGPPeer" in version "metallb.io/v1beta2"

@Gerrit91
Copy link
Contributor Author

Gerrit91 commented Jan 23, 2025

After installing MetalLB, the webhook cannot be reached from the metal-ccm / kube-api-server:

cloud-controller-manager-5c699bc6b8-757bq cloud-controller-manager E0123 16:25:58.825878       1 ticker.go:29] load balancer syncher failed: error updating load balancer config: Internal error occurred: failed calling webhook "bgppeersvalidationwebhook.metallb.io": failed to call webhook: Post "https://metallb-webhook-service.metallb-system.svc:443/validate-metallb-io-v1beta2-bgppeer?timeout=10s": context deadline exceeded

@robertvolkmann
Merge remote-tracking branch 'refs/remotes/origin/main' into metal-ccm
f53b6cf 
# Conflicts:
#	config/samples/example-kubeadm.yaml
@robertvolkmann
Copy link
Contributor

robertvolkmann commented Jan 27, 2025

After installing MetalLB, the webhook cannot be reached from the metal-ccm / kube-api-server:

cloud-controller-manager-5c699bc6b8-757bq cloud-controller-manager E0123 16:25:58.825878       1 ticker.go:29] load balancer syncher failed: error updating load balancer config: Internal error occurred: failed calling webhook "bgppeersvalidationwebhook.metallb.io": failed to call webhook: Post "https://metallb-webhook-service.metallb-system.svc:443/validate-metallb-io-v1beta2-bgppeer?timeout=10s": context deadline exceeded

Fixed by metal-stack/mini-lab#218

@robertvolkmann robertvolkmann marked this pull request as ready for review January 28, 2025 11:24
@robertvolkmann
Copy link
Contributor

robertvolkmann commented Jan 28, 2025

Announcing load balancer ip works now.

outside$ kubectl get svc -n ingress-nginx 
NAME                                 TYPE           CLUSTER-IP       EXTERNAL-IP     PORT(S)                      AGE
ingress-nginx-controller             LoadBalancer   10.110.114.188   203.0.113.131   80:30605/TCP,443:31094/TCP   14h
ingress-nginx-controller-admission   ClusterIP      10.111.57.203    <none>          443/TCP                      14h
outside$ curl 203.0.113.131
<html>
<head><title>404 Not Found</title></head>
<body>
<center><h1>404 Not Found</h1></center>
<hr><center>nginx</center>
</body>
</html>

@robertvolkmann robertvolkmann requested a review from simcod January 28, 2025 11:27
@simcod
Copy link
Contributor

simcod commented Jan 28, 2025

I tested on my side. The nodes do not have Internal IP addresses.

@robertvolkmann robertvolkmann merged commit 3219667 into main Jan 28, 2025
4 checks passed
@robertvolkmann robertvolkmann deleted the metal-ccm branch January 28, 2025 17:20
@robertvolkmann
Copy link
Contributor

robertvolkmann commented Jan 28, 2025

Worked on Simon's and my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simcod simcod Awaiting requested review from simcod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integrate a cloud-controller-manager

4 participants

@Gerrit91 @robertvolkmann @simcod