Skip to content

Remove ControlPlaneEndpoint from cluster-template.yaml because it will be set automatically #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertvolkmann merged 1 commit into from
Jan 27, 2025
Merged

Remove ControlPlaneEndpoint from cluster-template.yaml because it will be set automatically #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,6 @@ endef
export METAL_PARTITION ?= mini-lab
export METAL_PROJECT_ID ?= 00000000-0000-0000-0000-000000000001
export METAL_NODE_NETWORK_ID ?= $(shell metalctl network list --name metal-test -o template --template '{{ .id }}')
export CONTROL_PLANE_ENDPOINT ?= "203.0.113.129:443"
export CONTROL_PLANE_MACHINE_IMAGE ?= ubuntu-24.04
export CONTROL_PLANE_MACHINE_SIZE ?= v1-small-x86
export WORKER_MACHINE_IMAGE ?= ubuntu-24.04
Expand Down
8 changes: 3 additions & 5 deletions config/clusterctl-templates/cluster-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,11 @@ spec:
name: ${CLUSTER_NAME}-controlplane
kubeadmConfigSpec:
format: ignition
clusterConfiguration:
controlPlaneEndpoint: ${CONTROL_PLANE_ENDPOINT}
clusterConfiguration: {}
initConfiguration:
localAPIEndpoint:
advertiseAddress: 127.0.0.1
bindPort: ${CONTROL_PLANE_PORT:=443}
bindPort: 443
nodeRegistration: {}
joinConfiguration:
controlPlane: {}
Expand Down Expand Up @@ -117,7 +116,6 @@ spec:
template:
spec:
format: ignition
clusterConfiguration:
controlPlaneEndpoint: ${CONTROL_PLANE_ENDPOINT}
clusterConfiguration: {}
joinConfiguration:
nodeRegistration: {}
2 changes: 0 additions & 2 deletions config/clusterctl-templates/example_variables.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ export FIREWALL_MACHINE_SIZE=v1-small-x86
export FIREWALL_MACHINE_IMAGE=
export FIREWALL_NETWORKS=[internet]

export CONTROL_PLANE_ENDPOINT=203.0.113.129:443
export CONTROL_PLANE_PORT=443
export CONTROL_PLANE_MACHINE_SIZE=v1-small-x86
export CONTROL_PLANE_MACHINE_IMAGE=ubuntu-24.04

Expand Down
Loading