Skip to content

Conversation

@vknabel
Copy link
Contributor

@vknabel vknabel commented Jan 28, 2025

Description

Adds a few labels to metalstackmachine and some additional labels to the metal stack machines in order to be set on the node objects.

No tests needed to be updated as there are no machine tests yet.

Closes #58 #57

References:

metal_api_partitions:
- id: mini-lab
  # ....
  labels:
    partition.metal-stack.io/region: local
tags:
  # relevant tags of machine
  # these should also be added to the node object by metal-ccm
  - kubernetes.io/hostname=metal-test-controlplane-lw76m
  - topology.kubernetes.io/zone=mini-lab
  - topology.kubernetes.io/region=local
  - machine.metal-stack.io/rack=test-rack
  - machine.metal-stack.io/network.primary.asn=4210000030
  - metal-stack.infrastructure.cluster.x-k8s.io/machine-id=79d132cf-e58a-4cf5-acc8-233311256190
labels:
      # relevant labels of metalstackmachine
      kubernetes.io/hostname: metal-test-controlplane-lw76m
      machine.metal-stack.io/network.primary.asn: "4210000030"
      machine.metal-stack.io/rack: test-rack
      topology.kubernetes.io/region: local
      topology.kubernetes.io/zone: mini-lab

@vknabel vknabel marked this pull request as ready for review January 28, 2025 14:44
@vknabel vknabel merged commit b3a84d1 into main Jan 29, 2025
4 checks passed
@vknabel vknabel deleted the machine-labels branch January 29, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include the machine's ASN as a label

4 participants