Skip to content

Conversation

@majst01
Copy link
Contributor

@majst01 majst01 commented Jan 11, 2026

Description

Migrate to connectrpc simple which omits the requirement in every call to wrap the request in a connect.NewRequest(req), instead you can simply make the call with the req. Also the response is not wrapped in a .Msg field anymore.

Migrated to connectrpc simple, you need to adjust your client implementation.

@metal-robot metal-robot bot added area: control-plane Affects the metal-stack control-plane area. area: network Affects the network area. labels Jan 11, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2026

Codecov Report

❌ Patch coverage is 25.41667% with 179 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.48%. Comparing base (e451a48) to head (fbe77bc).

Files with missing lines Patch % Lines
api/v1/apiv1connect/ipam.connect.go 0.00% 105 Missing ⚠️
pkg/service/ipam-service.go 55.45% 43 Missing and 6 partials ⚠️
cmd/client/client.go 0.00% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
- Coverage   34.17%   33.48%   -0.70%     
==========================================
  Files          17       17              
  Lines        3125     3148      +23     
==========================================
- Hits         1068     1054      -14     
- Misses       1835     1872      +37     
  Partials      222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@majst01 majst01 self-assigned this Jan 11, 2026
@majst01 majst01 added the minor Breaking change or new feature, causes the release drafter to create a new minor version label Jan 11, 2026
@majst01 majst01 marked this pull request as ready for review January 11, 2026 16:05
@majst01 majst01 requested a review from a team as a code owner January 11, 2026 16:05
@majst01 majst01 force-pushed the migrate-to-connect-simple branch from 106d5fe to 83738ac Compare January 11, 2026 16:07
@majst01 majst01 force-pushed the migrate-to-connect-simple branch from 83738ac to fbe77bc Compare January 15, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: control-plane Affects the metal-stack control-plane area. area: network Affects the network area. minor Breaking change or new feature, causes the release drafter to create a new minor version

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants