Memory datastore #111
Merged
Memory datastore #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vknabel
reviewed
Mar 17, 2025
pkg/datastore/memory.go
Outdated
|
|
||
| // DeleteAll implements Storage. | ||
| func (m *memoryDatastore[E]) DeleteAll(ctx context.Context, ids ...string) error { | ||
| panic("unimplemented") |
There was a problem hiding this comment.
Do we want to implement this? Should be fairly easy
2 tasks
Contributor
Author
|
#114 should be merged first |
vknabel
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is handy for testing only to get rid of ugly mocks. Does not work for all Tenant Service Methods because there is the sql connection used directly.
Only useful for tests where CRUD operation on the available Entities are required. Find operations and operations where additional queries are called does not work.
depends on: #114