Skip to content

Fix misleading error messages #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majst01 merged 1 commit into from
Apr 7, 2025
Merged

Fix misleading error messages #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/datastore/memory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func (m *memoryDatastore[E]) Delete(ctx context.Context, id string) error {

_, ok := m.entities[id]
if !ok {
return NewNotFoundError(fmt.Sprintf("not found: delete of %s with id %s", m.entity, id))
return NewNotFoundError(fmt.Sprintf("delete of %s with id %s", m.entity, id))
}
delete(m.entities, id)

Expand Down Expand Up @@ -94,7 +94,7 @@ func (m *memoryDatastore[E]) Get(ctx context.Context, id string) (E, error) {

e, ok := m.entities[id]
if !ok {
return zero, NewNotFoundError(fmt.Sprintf("not found: delete of %s with id %s", m.entity, id))
return zero, NewNotFoundError(fmt.Sprintf("get of %s with id %s", m.entity, id))
}

return e, nil
Expand Down Expand Up @@ -123,7 +123,7 @@ func (m *memoryDatastore[E]) Update(ctx context.Context, ve E) error {

_, ok := m.entities[id]
if !ok {
return NewNotFoundError(fmt.Sprintf("not found: delete of %s with id %s", m.entity, id))
return NewNotFoundError(fmt.Sprintf("update of %s with id %s", m.entity, id))
}

m.entities[id] = ve
Expand Down