Conversation
…o ipv6-support
…o ipv6-support
5919c8f to
0c53831
Compare
0c53831 to
2389965
Compare
8 tasks
…o dualstack-support
d49d2c0 to
b65c835
Compare
majst01
commented
Aug 1, 2024
23a3d1e to
89096c0
Compare
…o dualstack-support
a3571a2 to
d9667d3
Compare
majst01
commented
Feb 3, 2025
vknabel
reviewed
Feb 10, 2025
Contributor
vknabel
left a comment
There was a problem hiding this comment.
Fine from my side. If you address the comments from gerrit, this should be ready to go :)
iljarotar
approved these changes
Feb 12, 2025
majst01
commented
Feb 17, 2025
| afs = append(afs, af) | ||
| } | ||
| } | ||
| new.AddressFamilies = afs |
Contributor
Author
There was a problem hiding this comment.
TODO check if required to store AF in the db
majst01
commented
Feb 17, 2025
| return | ||
| } | ||
| if !slices.Contains(nw.AddressFamilies, af) { | ||
| r.sendError(request, response, httperrors.BadRequest( |
Contributor
Author
There was a problem hiding this comment.
Check if this error is really thrown
Gerrit91
approved these changes
Feb 17, 2025
vknabel
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #164
Actions Required
Depends on:
replaces #544
TODO: