Skip to content

If the grpc certificate changed, reboot metal-hammer#605

Merged
majst01 merged 3 commits intomasterfrom
reboot-metal-hammer-if-certificate-changed
Feb 4, 2025
Merged

If the grpc certificate changed, reboot metal-hammer#605
majst01 merged 3 commits intomasterfrom
reboot-metal-hammer-if-certificate-changed

Conversation

@majst01
Copy link
Contributor

@majst01 majst01 commented Jan 30, 2025

Description

During the tests to rotate the ca and all certificates, waiting metal-hammer instances did not reboot.
Fix this in a ugly manner.

Related: metal-stack/metal-hammer#150

@majst01 majst01 requested a review from a team as a code owner January 30, 2025 06:37
@majst01 majst01 requested a review from mwennrich January 30, 2025 06:37
@Gerrit91
Copy link
Contributor

Theoretically I think we could try it with errors.Is, too: https://github.com/golang/go/blob/e81f7155154c0f5d40363e84a8f24a5b559b5eed/src/crypto/x509/verify.go#L141-L149

@majst01 majst01 merged commit 96729c0 into master Feb 4, 2025
2 checks passed
@majst01 majst01 deleted the reboot-metal-hammer-if-certificate-changed branch February 4, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants