Skip to content

Use id.Get to simplify update#45

Closed
majst01 wants to merge 21 commits intomainfrom
simplify-update
Closed

Use id.Get to simplify update#45
majst01 wants to merge 21 commits intomainfrom
simplify-update

Conversation

@majst01
Copy link
Contributor

@majst01 majst01 commented Jun 20, 2025

Description

Use metal-stack/api#14 to simplify update.

We should discuss if this is worth the effort.

@Gerrit91 Gerrit91 moved this to In Progress in Development Jun 30, 2025
Base automatically changed from trying-around to main July 5, 2025 11:22
@majst01 majst01 marked this pull request as ready for review July 5, 2025 11:35
@majst01 majst01 requested a review from a team as a code owner July 5, 2025 11:35
@codecov
Copy link

codecov bot commented Jul 5, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.67%. Comparing base (8fe1a88) to head (5655aac).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
pkg/repository/store.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   58.68%   58.67%   -0.02%     
==========================================
  Files          81       81              
  Lines        8905     8909       +4     
==========================================
+ Hits         5226     5227       +1     
- Misses       3171     3173       +2     
- Partials      508      509       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gerrit91 Gerrit91 moved this from In Progress to Backlog in Development Sep 8, 2025
@majst01
Copy link
Contributor Author

majst01 commented Sep 11, 2025

Decision was made that this approach is not worth the effort, closing

@majst01 majst01 closed this Sep 11, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Development Sep 11, 2025
@majst01 majst01 deleted the simplify-update branch September 11, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants